Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs: Refactor MDX examples to sandboxes #19301

Merged
merged 15 commits into from
Oct 10, 2022
Merged

Addon-docs: Refactor MDX examples to sandboxes #19301

merged 15 commits into from
Oct 10, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Sep 30, 2022 •
edited
Loading

Issue: N/A

What I did

  • Configure sandbox for docs1/docs2 MDX stories
  • Create generic MDX stories
  • Create renderer-specific MDX stories
  • Delete MDX stories from examples

How to test

  • CI passes

@shilman shilman added maintenance User-facing maintenance tasks addon: docs labels Sep 30, 2022
tmeasday
tmeasday approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice LGTM

@shilman shilman marked this pull request as ready for review October 10, 2022 03:49
@shilman shilman merged commit 7bfe290 into next Oct 10, 2022
@shilman shilman deleted the shilman/generic-mdx-stories branch October 10, 2022 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees

@shilman shilman

Labels
addon: docs maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shilman @tmeasday @ndelangen